Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(apps): add dockedControls to app layout, configure and animate existing actions #797

Merged
merged 1 commit into from
Oct 29, 2024
Merged

feat(apps): add dockedControls to app layout, configure and animate existing actions #797

merged 1 commit into from
Oct 29, 2024

Conversation

alexfreska
Copy link
Member

@alexfreska alexfreska commented Oct 24, 2024 •
edited
Loading

  • This PR adds a persistent "docked controls" overlay area to the app layout. This is used for controls such as the onboarding wizard, transfers bar, and now all the multiselect menus. Docked controls are persistent across pages which allows any global controls to stay mounted between navigations, and page specific controls can be added and removed.
  • Added dockedControls to AppAuthedLayout.
  • All relevant controls have been moved into the docked controls area.
  • The onboarding wizard now animates in and out.
  • The transfers bar now animates in and out.
Screenshot 2024-10-28 at 4 14 39 PM

@vercel Vercel
Copy link

vercel bot commented Oct 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hostd ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 11:23pm
renterd ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 11:23pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Oct 28, 2024 11:23pm
explorer-zen ⬜️ Ignored (Inspect) Visit Preview Oct 28, 2024 11:23pm
website ⬜️ Ignored (Inspect) Visit Preview Oct 28, 2024 11:23pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: bde6f3a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@siafoundation/design-system Minor
hostd Minor
renterd Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

This was referenced Oct 24, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@alexfreska Graphite App
Copy link
Member Author

alexfreska commented Oct 24, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Oct 24, 2024
Merged
Merged
@alexfreska alexfreska changed the title feat(apps): add bottom actions to app layout, configure and animate existing actions feat(apps): add dockedControls to app layout, configure and animate existing actions Oct 25, 2024
@alexfreska alexfreska force-pushed the refactor_apps_persist_layouts_between_page_transitions branch from a0316dc to e80566c Compare October 25, 2024 16:47
@alexfreska alexfreska force-pushed the refactor_apps_persist_layouts_between_page_transitions branch from e80566c to b3d0c9f Compare October 25, 2024 17:45
@alexfreska alexfreska mentioned this pull request Oct 25, 2024
Merged
@alexfreska alexfreska force-pushed the refactor_apps_persist_layouts_between_page_transitions branch from b3d0c9f to 91b712f Compare October 25, 2024 18:59
@alexfreska alexfreska force-pushed the refactor_apps_persist_layouts_between_page_transitions branch from 91b712f to 9ec9900 Compare October 25, 2024 19:36
@alexfreska alexfreska force-pushed the refactor_apps_persist_layouts_between_page_transitions branch from 9ec9900 to 41da4e8 Compare October 25, 2024 19:43
@alexfreska alexfreska requested review from telestrial and removed request for telestrial October 28, 2024 16:07
@alexfreska alexfreska force-pushed the feat_actions_bottom branch 2 times, most recently from 568655d to 91af927 Compare October 28, 2024 17:01
@alexfreska alexfreska changed the base branch from refactor_apps_persist_layouts_between_page_transitions to graphite-base/797 October 28, 2024 17:17
@alexfreska alexfreska changed the base branch from graphite-base/797 to main October 28, 2024 17:20
@alexfreska alexfreska requested a review from telestrial October 28, 2024 23:15
@alexfreska alexfreska mentioned this pull request Oct 29, 2024
Merged
@alexfreska Graphite App
Copy link
Member Author

alexfreska commented Oct 29, 2024 •
edited
Loading

Merge activity

  • Oct 29, 2:54 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 29, 2:54 PM EDT: A user merged this pull request with Graphite.

@alexfreska alexfreska merged commit ed264a0 into main Oct 29, 2024
37 checks passed
@alexfreska alexfreska deleted the feat_actions_bottom branch October 29, 2024 18:54
This was referenced Oct 29, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@telestrial telestrial telestrial approved these changes

Assignees

@alexfreska alexfreska

Labels
None yet
Projects
Sia
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexfreska @telestrial